Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-42027: new stack segfault with libpq #102

Merged
merged 1 commit into from
Dec 5, 2023
Merged

DM-42027: new stack segfault with libpq #102

merged 1 commit into from
Dec 5, 2023

Conversation

hsinfang
Copy link
Collaborator

@hsinfang hsinfang commented Dec 5, 2023

No description provided.

@kfindeisen
Copy link
Member

Hmm... looks like there's a bug in the GHA config; it's building the base container but not the service one. 😞

@hsinfang
Copy link
Collaborator Author

hsinfang commented Dec 5, 2023

I thought it's a deliberate choice not to build a new service container with just the Dockerfile.main change?

kfindeisen
kfindeisen approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense, but please do test on dev.

Dockerfile.main Outdated
@@ -6,5 +6,6 @@ RUN source /opt/lsst/software/stack/loadLSST.bash \
flask \
gunicorn \
python-confluent-kafka \
openssl=3.1.4 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add a comment here that this is a workaround for DM-XXXXX?

I'm not familiar with mamba, so I don't know how this line will interact with Conda's rubin-env. I think it would be good to test this before merging.

@kfindeisen
Copy link
Member

kfindeisen commented Dec 5, 2023 •
edited
Loading

I thought it's a deliberate choice not to build a new service container with just the Dockerfile.main change?

Sorry, just saw your comment on Jira. You're right, you'd have to override BASE_TAG_LIST for a branch service build to be meaningful anyway.

@timj
Copy link
Member

timj commented Dec 5, 2023 •
edited
Loading

I think conda-forge have fixed the libpq problem now.

conda-forge/conda-forge-repodata-patches-feedstock#598

@hsinfang
Copy link
Collaborator Author

hsinfang commented Dec 5, 2023

As of earlier today when I tested d_2023_12_05 on prompt processing dev it still crashed. It had openssl 3.2.0.

Not familiar with our whole stack building process well enough, and not finding a jira DM ticket... how do I know if/when the workaround is no longer necessary, except deploying to dev to test?

I'll definitely test in dev before touching prod.

@hsinfang
Pin openssl until upstream is fixed
82b0a77 
openssl 3.2.0 conflicts with libpq, leading to segfault in butler.

This workaround should be removed once the upstream is fixed.
@hsinfang hsinfang merged commit c2d51f9 into main Dec 5, 2023
3 checks passed
@hsinfang hsinfang deleted the tickets/DM-42027 branch December 5, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfindeisen kfindeisen kfindeisen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsinfang @kfindeisen @timj